Chargeback: Fix rate adjustment rounding bug #13331
Merged
+32
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug
branch
2 times, most recently
from
b5d826a
to
c5ff669
Compare
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug
branch
2 times, most recently
from
c8973a2
to
5f37575
Compare
lpichler
reviewed
Jan 6, 2017
| # derived_vm_allocated_disk_storage --> bytes | ||
| # derived_vm_used_disk_storage --> bytes | ||
| # Scale the rate in the unit defined by user -> to the default unit of the metric | ||
| MetricUnits = { |
There was a problem hiding this comment.
MetricUnits -> METRIC_UNITS ?
There was a problem hiding this comment.
A man can learn many languages. But my brain does not scale to remember all the naming conventions. :-(
Thanks for keeping an eye on me, when rubocop is not.
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug
branch
7 times, most recently
from
96d5f9e
to
3530a8c
Compare
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug
branch
4 times, most recently
from
c952f05
to
1d2c1c9
Compare
gtanzillo
approved these changes
Jan 18, 2017
|
@isimluk It seems the test failures are related. |
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug
branch
4 times, most recently
from
0477fe0
to
e3c91f5
Compare
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug
branch
from
e3c91f5
to
29d1e70
Compare
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug
branch
4 times, most recently
from
ee36e91
to
074c6cb
Compare
This is teached in 7th or 8th grade, so backend developers shall comprehend.
The adjustment is function of two units. It is not function of a value. It is independent. It does not depend on each other. The value does not affect the adjustment measure.
Like they do in algebra classes.
Hash can be re-used as it refers to what MetricRollup table contains.
Then we can memoize it and save some time calculating it again and again.
Float has insufficient precision. Already 1024**-3 causes problems.
Certain version of ruby (before 2.3.3) have problems with BigDecimal.new(1) <= Float::INFINITY or Float::INFINITY >= BigDecimal.new(1) Forcing BigDecimal to float in this case will not hurt.
isimluk
force-pushed
the
fix-rate-adjustment-rounding-bug
branch
from
a6b0aa4
to
bb40e8a
Compare
|
Checked commits isimluk/manageiq@839660c~...bb40e8a with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0 |
|
Thanks! Specs are now fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reproducer
Consider the following scenario with disk_allocation_metric:
Found in #13269.
@miq-bot add_label chargeback, bug, euwe/no